svn commit: r281734 - head/usr.sbin/inetd

Sergey Kandaurov pluknet at freebsd.org
Sun Apr 19 09:17:33 UTC 2015


On 19 April 2015 at 12:07, Eitan Adler <eadler at freebsd.org> wrote:
> Author: eadler
> Date: Sun Apr 19 09:07:57 2015
> New Revision: 281734
> URL: https://svnweb.freebsd.org/changeset/base/281734
>
> Log:
>   identd: remove redundant zeroing
>         se_rpc_lowvers was set to 0 twice, so remove one of them
>         I can not find any other variable which they may have been a typo of.
>
>   Reported by:  gcc5.1
>
> Modified:
>   head/usr.sbin/inetd/inetd.c
>
> Modified: head/usr.sbin/inetd/inetd.c
> ==============================================================================
> --- head/usr.sbin/inetd/inetd.c Sun Apr 19 08:45:37 2015        (r281733)
> +++ head/usr.sbin/inetd/inetd.c Sun Apr 19 09:07:57 2015        (r281734)
> @@ -1752,8 +1752,7 @@ more:
>                  memmove(sep->se_proto, sep->se_proto + 4,
>                      strlen(sep->se_proto) + 1 - 4);
>                  sep->se_rpc = 1;
> -                sep->se_rpc_prog = sep->se_rpc_lowvers =
> -                       sep->se_rpc_lowvers = 0;
> +                sep->se_rpc_prog = sep->se_rpc_lowvers = 0;
>                 memcpy(&sep->se_ctrladdr4, bind_sa4,
>                        sizeof(sep->se_ctrladdr4));
>                  if ((versp = strrchr(sep->se_service, '/'))) {
>

se_rpc_highvers ?
They both seem to be used prezeroed in a later sscanf().

-- 
wbr,
pluknet


More information about the svn-src-all mailing list