svn commit: r281008 - head/sys/dev/ciss

Peter Wemm peter at FreeBSD.org
Thu Apr 2 23:12:19 UTC 2015


Author: peter
Date: Thu Apr  2 23:12:18 2015
New Revision: 281008
URL: https://svnweb.freebsd.org/changeset/base/281008

Log:
  Remove redundant mtx_lock/unlock in ciss_name_device. This is a guaranteed
  insta-panic on device add/remove.  This is only called from the notify
  thread which already holds the lock while calling this function.

Modified:
  head/sys/dev/ciss/ciss.c

Modified: head/sys/dev/ciss/ciss.c
==============================================================================
--- head/sys/dev/ciss/ciss.c	Thu Apr  2 22:42:23 2015	(r281007)
+++ head/sys/dev/ciss/ciss.c	Thu Apr  2 23:12:18 2015	(r281008)
@@ -3438,11 +3438,9 @@ ciss_name_device(struct ciss_softc *sc, 
 			     target, 0);
 
     if (status == CAM_REQ_CMP) {
-	mtx_lock(&sc->ciss_mtx);
 	xpt_path_lock(path);
 	periph = cam_periph_find(path, NULL);
 	xpt_path_unlock(path);
-	mtx_unlock(&sc->ciss_mtx);
 	xpt_free_path(path);
 	if (periph != NULL) {
 		sprintf(sc->ciss_logical[bus][target].cl_name, "%s%d",


More information about the svn-src-all mailing list