svn commit: r247570 - head/sys/dev/aac

[Ryan Stone]

On Fri, Mar 1, 2013 at 2:55 PM, Marius Strobl <marius at freebsd.org> wrote:

> Author: marius
> Date: Fri Mar  1 19:55:10 2013
> New Revision: 247570
> URL: http://svnweb.freebsd.org/changeset/base/247570
>
> Log:
>   - Make tables, device ID strings etc const. This includes #ifdef'ing 0
>     aac_command_status_table, which is actually unused since r111532.
>     While at it, make aac_if a pointer to the now const interface tables
>     instead of copying them over to the softc (this alone already reduces
> the
>     size of aac.ko on amd64 by ~1 KiB).
>   - Remove redundant softc members.
>   - Use DEVMETHOD_END.
>   - Use NULL instead of 0 for pointers.
>   - Remove redundant bzero(9)'ing of the softc.
>   - Use pci_enable_busmaster(9) instead of duplicating it.
>   - Remove redundant checking for PCIM_CMD_MEMEN (resource allocation will
>     just fail).
>   - Canonicalize the error messages in case of resource allocation
> failures.
>   - Add support for using MSI instead of INTx, controllable via the tunable
>     hw.aac.enable_msi (defaulting to on).
>

This doesn't seem to be working for the 2230S controller.  It panics at
mountroot with "panic: run_interrupt_driven_config_hooks".  It works if I
set hw.aac.enable_msi=0.  This is happening with two different
motherboards, so I'm not entirely sure if the problem is the BIOS or the
driver.  I put a verbose boot log here:
http://people.freebsd.org/~rstone/aac_msi.log