svn commit: r248394 - head/tools/regression/security/cap_test

Pawel Jakub Dawidek pjd at FreeBSD.org
Sat Mar 16 23:10:41 UTC 2013


Author: pjd
Date: Sat Mar 16 23:10:40 2013
New Revision: 248394
URL: http://svnweb.freebsd.org/changeset/base/248394

Log:
  The mode argument for open(2)/openat(2) only makes sense if the O_CREAT flag
  was given.
  
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/tools/regression/security/cap_test/cap_test_capabilities.c

Modified: head/tools/regression/security/cap_test/cap_test_capabilities.c
==============================================================================
--- head/tools/regression/security/cap_test/cap_test_capabilities.c	Sat Mar 16 22:53:38 2013	(r248393)
+++ head/tools/regression/security/cap_test/cap_test_capabilities.c	Sat Mar 16 23:10:40 2013	(r248394)
@@ -207,27 +207,27 @@ try_file_ops(int filefd, int dirfd, cap_
 	ret = openat(dirfd, "cap_fsync", O_CREAT, 0600);
 	CHECK(ret >= 0);
 	CHECK(close(ret) == 0);
-	ret = openat(dfd_cap, "cap_fsync", O_FSYNC | O_RDONLY, 0600);
+	ret = openat(dfd_cap, "cap_fsync", O_FSYNC | O_RDONLY);
 	CHECK_RESULT(openat(O_FSYNC | O_RDONLY),
 	    CAP_FSYNC | CAP_READ | CAP_LOOKUP, ret >= 0);
 	CHECK(ret == -1 || close(ret) == 0);
-	ret = openat(dfd_cap, "cap_fsync", O_FSYNC | O_WRONLY, 0600);
+	ret = openat(dfd_cap, "cap_fsync", O_FSYNC | O_WRONLY);
 	CHECK_RESULT(openat(O_FSYNC | O_WRONLY),
 	    CAP_FSYNC | CAP_WRITE | CAP_LOOKUP, ret >= 0);
 	CHECK(ret == -1 || close(ret) == 0);
-	ret = openat(dfd_cap, "cap_fsync", O_FSYNC | O_RDWR, 0600);
+	ret = openat(dfd_cap, "cap_fsync", O_FSYNC | O_RDWR);
 	CHECK_RESULT(openat(O_FSYNC | O_RDWR),
 	    CAP_FSYNC | CAP_READ | CAP_WRITE | CAP_LOOKUP, ret >= 0);
 	CHECK(ret == -1 || close(ret) == 0);
-	ret = openat(dfd_cap, "cap_fsync", O_SYNC | O_RDONLY, 0600);
+	ret = openat(dfd_cap, "cap_fsync", O_SYNC | O_RDONLY);
 	CHECK_RESULT(openat(O_SYNC | O_RDONLY),
 	    CAP_FSYNC | CAP_READ | CAP_LOOKUP, ret >= 0);
 	CHECK(ret == -1 || close(ret) == 0);
-	ret = openat(dfd_cap, "cap_fsync", O_SYNC | O_WRONLY, 0600);
+	ret = openat(dfd_cap, "cap_fsync", O_SYNC | O_WRONLY);
 	CHECK_RESULT(openat(O_SYNC | O_WRONLY),
 	    CAP_FSYNC | CAP_WRITE | CAP_LOOKUP, ret >= 0);
 	CHECK(ret == -1 || close(ret) == 0);
-	ret = openat(dfd_cap, "cap_fsync", O_SYNC | O_RDWR, 0600);
+	ret = openat(dfd_cap, "cap_fsync", O_SYNC | O_RDWR);
 	CHECK_RESULT(openat(O_SYNC | O_RDWR),
 	    CAP_FSYNC | CAP_READ | CAP_WRITE | CAP_LOOKUP, ret >= 0);
 	CHECK(ret == -1 || close(ret) == 0);


More information about the svn-src-all mailing list