svn commit: r247823 - head/sys/dev/ixgbe

Jack F Vogel jfv at FreeBSD.org
Mon Mar 4 23:15:08 UTC 2013


Author: jfv
Date: Mon Mar  4 23:15:07 2013
New Revision: 247823
URL: http://svnweb.freebsd.org/changeset/base/247823

Log:
  Fix a small, but important bug, a task drain was mistakenly
  being compiled only when setting LEGACY_TX, this means you would
  not get the drain when needed on detach!!
  
  Thanks to Bryan Venteicher (bryanv at freebsd.org) for catching this
  little gremlin!! :)

Modified:
  head/sys/dev/ixgbe/ixgbe.c

Modified: head/sys/dev/ixgbe/ixgbe.c
==============================================================================
--- head/sys/dev/ixgbe/ixgbe.c	Mon Mar  4 23:07:40 2013	(r247822)
+++ head/sys/dev/ixgbe/ixgbe.c	Mon Mar  4 23:15:07 2013	(r247823)
@@ -654,7 +654,7 @@ ixgbe_detach(device_t dev)
 
 	for (int i = 0; i < adapter->num_queues; i++, que++, txr++) {
 		if (que->tq) {
-#ifdef IXGBE_LEGACY_TX
+#ifndef IXGBE_LEGACY_TX
 			taskqueue_drain(que->tq, &txr->txq_task);
 #endif
 			taskqueue_drain(que->tq, &que->que_task);


More information about the svn-src-all mailing list