svn commit: r245506 - head/bin/pwait

[Eitan Adler]

On 16 January 2013 21:25, Bruce Evans <brde at optusnet.com.au> wrote:
> This uses the sysexits mistake.  style(9) was fixed to not give an example
> of this mistake.  Before this, sysexits was used a whole once in pwait(1)
> (for EX_USAGE) in usage().  EX_USAGE happens to be 64.  As usual when the
> mistake is used, this is useless for humans (the usage message gives more
> info) and unusable for programs, especially since it is undocmented
> (pwait(1)'s man page just says ">0 if an error occurs".  It doesn't even
> use '.Std' for this, but hard-codes it.

IMHO using sysexits gives more signal than using a binary 0 or 1.  It
is a mistake to have changed style(9) to avoid using sysexits.
Instead the man page should detail the specific error that occurs
directly, or by reference to sysexit.

-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams