svn commit: r245494 - head/bin/pwait

Eitan Adler eadler at freebsd.org
Wed Jan 16 17:48:24 UTC 2013


On 16 January 2013 01:49, Xin LI <delphij at gmail.com> wrote:
> This doesn't seem right -- you should never release memory before exit,
> especially for memory allocated in main(), unless this "main" is intended
> for different purpose like a monolithic shell that wants to avoid exec().
> Note that pwait(1) have multiple exit points I don't think it's practical.

...

There have been multiple conversations about this: on hackers, on the
commit lists, and on the clang analyzer lists.

I don't care much how the final code looks: with either free or return
but please make sure that scan-build finds no warnings.

-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams


More information about the svn-src-all mailing list