svn commit: r244585 - in head: . sys/geom/label

[Warner Losh]

On Jan 9, 2013, at 4:45 PM, Konstantin Belousov wrote:

> On Wed, Jan 09, 2013 at 02:17:37PM -0500, John Baldwin wrote:
>> On Tuesday, January 08, 2013 2:31:47 pm Jaakko Heinonen wrote:
>>> On 2013-01-07, John Baldwin wrote:
>>>> I think if it isn't hard to do so, we should aim to preserve labels as they 
>>>> are generally intended to be human readable as-is.  Just preserving spaces is 
>>>> probably sufficient for this as they are probably the most commonly used 
>>>> character in labels affected by this change.
>>> 
>>> All right. I have prepared patches for review.
>>> 
>>> - Quote device names in devctl(4) device events. This allows events to
>>>  work for device names containing spaces.
>>> - Allow spaces again in device names.
>>> 
>>> Requested by:	jhb
>>> PR:		kern/161912
>> 
>> Thanks.  I think your patches look fine as far as I can tell.
> 
> I do not object, but IMHO having names with the spaces in /dev is weird
> and possibly problematic. This was the reason of my initial request to
> disable spaces, together with the fact that it changes the devctl(4)
> protocol (there might be other /dev/devctl readers besides devd).

I'm not sure that the protocol changes are quire right yet...

Warner