svn commit: r247300 - in head: sys/sys usr.bin/truss

[Davide Italiano]

On Tue, Feb 26, 2013 at 7:35 PM, John Baldwin <jhb at freebsd.org> wrote:
> On Tuesday, February 26, 2013 12:09:42 pm Davide Italiano wrote:
>> On Tue, Feb 26, 2013 at 3:41 PM, John Baldwin <jhb at freebsd.org> wrote:
>> > On Monday, February 25, 2013 9:13:02 pm Xin LI wrote:
>> >> Author: delphij
>> >> Date: Tue Feb 26 02:13:02 2013
>> >> New Revision: 247300
>> >> URL: http://svnweb.freebsd.org/changeset/base/247300
>> >>
>> >> Log:
>> >>   Expose timespec and timeval macros when __BSD_VISIBLE is defined.  This
>> >>   allows userland application to use the following macros:
>> >>
>> >>       timespecclear, timespecisset, timespeccmp, timespecadd,
>> >>       timespecsub;
>> >>
>> >>       timevalclear, timevalisset, timevalcmp.
>> >
>> > Why not fix truss to use the stock functions instead of keeping private
>> > "unusual" versions?
>> >
>> > --
>> > John Baldwin
>>
>> time.h is already a mess in terms of namespace pollution, and this
>> exposure might not help thing.
>> Other details here:
>> http://permalink.gmane.org/gmane.os.freebsd.architechture/15518
>
> I think that is orthogonal.  Even if this is reverted I think truss should
> be changed to use the "normal" timespecsubt() macro rather than using a custom
> one with a different argument order.
>
> --
> John Baldwin

When I talked about "exposure" I referred about timeval/timespec
macros(). I wasn't arguing about your proposed change.
Sorry if it wasn't clear.

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare