svn commit: r247109 - head/sys/dev/firewire

Warner Losh imp at FreeBSD.org
Thu Feb 21 17:50:22 UTC 2013


Author: imp
Date: Thu Feb 21 17:50:21 2013
New Revision: 247109
URL: http://svnweb.freebsd.org/changeset/base/247109

Log:
  bus_dmamap_load_ccb doesn't exist on earlier versions of FreeBSD or
  DragonFlyBSD, so it certainly doesn't need splsoftvm(). Remove it.
  
  # I doubt this driver will now compile on older FreeBSD versions or DFBSD
  # We should consider unifdefing it since that code seems unmaintained.

Modified:
  head/sys/dev/firewire/sbp.c

Modified: head/sys/dev/firewire/sbp.c
==============================================================================
--- head/sys/dev/firewire/sbp.c	Thu Feb 21 17:40:59 2013	(r247108)
+++ head/sys/dev/firewire/sbp.c	Thu Feb 21 17:50:21 2013	(r247109)
@@ -2488,16 +2488,14 @@ printf("ORB %08x %08x %08x %08x\n", ntoh
 printf("ORB %08x %08x %08x %08x\n", ntohl(ocb->orb[4]), ntohl(ocb->orb[5]), ntohl(ocb->orb[6]), ntohl(ocb->orb[7]));
 */
 		if (ccb->csio.dxfer_len > 0) {
-			int s, error;
+			int error;
 
-			s = splsoftvm();
 			error = bus_dmamap_load_ccb(/*dma tag*/sbp->dmat,
 					/*dma map*/ocb->dmamap,
 					ccb,
 					sbp_execute_ocb,
 					ocb,
 					/*flags*/0);
-			splx(s);
 			if (error)
 				printf("sbp: bus_dmamap_load error %d\n", error);
 		} else


More information about the svn-src-all mailing list