svn commit: r259896 - head/sys/dev/cxgb/common

[Adrian Chadd]

Hi Dim,

I'd prefer you didn't remove unused code in drivers like this. If you
must, #if 0 them out.

Future people hacking on the driver may find it nice to have as much
code in there which talks to the hardware. It may not be currently
called, but it's at least there.

Thanks,



-adrian


On 25 December 2013 14:45, Dimitry Andric <dim at freebsd.org> wrote:
> Author: dim
> Date: Wed Dec 25 22:45:33 2013
> New Revision: 259896
> URL: http://svnweb.freebsd.org/changeset/base/259896
>
> Log:
>   In sys/dev/cxgb/common/cxgb_mc5.c, remove static function
>   dbgi_wr_addr3(), which is unused since r167514.
>
>   MFC after:    3 days
>
> Modified:
>   head/sys/dev/cxgb/common/cxgb_mc5.c
>
> Modified: head/sys/dev/cxgb/common/cxgb_mc5.c
> ==============================================================================
> --- head/sys/dev/cxgb/common/cxgb_mc5.c Wed Dec 25 22:36:27 2013        (r259895)
> +++ head/sys/dev/cxgb/common/cxgb_mc5.c Wed Dec 25 22:45:33 2013        (r259896)
> @@ -98,13 +98,6 @@ static int mc5_cmd_write(adapter_t *adap
>                                F_DBGIRSPVALID, 1, MAX_WRITE_ATTEMPTS, 1);
>  }
>
> -static inline void dbgi_wr_addr3(adapter_t *adapter, u32 v1, u32 v2, u32 v3)
> -{
> -       t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_ADDR0, v1);
> -       t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_ADDR1, v2);
> -       t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_ADDR2, v3);
> -}
> -
>  static inline void dbgi_wr_data3(adapter_t *adapter, u32 v1, u32 v2, u32 v3)
>  {
>         t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_DATA0, v1);