svn commit: r255074 - head/sys/dev/uart

Marcel Moolenaar marcel at FreeBSD.org
Fri Aug 30 15:26:46 UTC 2013


Author: marcel
Date: Fri Aug 30 15:26:45 2013
New Revision: 255074
URL: http://svnweb.freebsd.org/changeset/base/255074

Log:
  A final test with unmodified code has shown that a delay of 150ms
  is not giving us a 100% success rate. Bump the delay to 200ms as
  that seems to do the trick.
  
  Note that during testing the delay was added to uart_bus_attach()
  in uart_core.c. While having the delay in a different place can
  change the behaviour, it was not expected. Having to bump the
  delay with another 50ms could therefore be an indication that
  the problem can not be solved with delays.
  
  Reported by: kevlo@
  Tested by: kevlo@

Modified:
  head/sys/dev/uart/uart_dev_ns8250.c

Modified: head/sys/dev/uart/uart_dev_ns8250.c
==============================================================================
--- head/sys/dev/uart/uart_dev_ns8250.c	Fri Aug 30 13:25:15 2013	(r255073)
+++ head/sys/dev/uart/uart_dev_ns8250.c	Fri Aug 30 15:26:45 2013	(r255074)
@@ -465,7 +465,7 @@ ns8250_bus_attach(struct uart_softc *sc)
 	 * accidental manner as before. More analysis is warranted, but
 	 * at least now we fixed a known regression.
 	 */
-	DELAY(150);
+	DELAY(200);
 	return (0);
 }
 


More information about the svn-src-all mailing list