svn commit: r246880 - in head: lib/libsm libexec/mail.local libexec/smrsh share/mk usr.bin/vacation usr.sbin/sendmail

[Giorgos Keramidas]

On Tue, 16 Apr 2013 11:03:01 +0200, Dimitry Andric <dim at FreeBSD.org> wrote:
> On 2013-04-16 06:19, Γιώργος Κεραμίδας wrote:
>> On Sat, 16 Feb 2013 20:17:31 +0000 (UTC), Dimitry Andric <dim at FreeBSD.org> wrote:
> ...
>>>    Since clang 3.2 now has an option to suppress warnings about implicitly
>>>    promoted K&R parameters, remove the workarounds added for sendmail
>>>    components in r228558.
> ...
>> The part of the commit that removes NO_WERROR.clang for usr.sbin/sendmail/
>> breaks the build of Sendmail with -DSASL.  I just tried rebuilding Sendmail
>> with the following in "/etc/make.conf":
>>
>>      # Build Sendmail with SASL support.
>>      SENDMAIL_CFLAGS ?= -I/usr/local/include -DSASL=20126
>>      SENDMAIL_LDFLAGS ?= -L/usr/local/lib
>>      SENDMAIL_LDADD ?= -lsasl2
>>
>> The warnings that usersmtp.c still triggers when -DSASL is used are:
>>
>> : cc -O2 -pipe -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/src
>> -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/include
>> -I. -DNEWDB -DNIS -DTCPWRAPPERS -DMAP_REGEX -DDNSMAP -DNETINET6
>> -DSTARTTLS -D_FFR_TLS_1 -I/usr/local/include -DSASL=20126 -std=gnu99
>> -Qunused-arguments -fstack-protector -Wsystem-headers
>> -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int
>> -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality
>> -Wno-unused-function -Wno-conversion -Wno-switch -Wno-switch-enum
>> -Wno-knr-promoted-parameter -Wno-parentheses -c
>> /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c
>> :
>> /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c:1797:50:
>> warning: incompatible pointer types passing 'void ()' to parameter of
>> type 'void (*)(char *, bool, MAILER *, struct
>> :       mailer_con_info *, ENVELOPE *)' [-Wincompatible-pointer-types]
>> :         smtpresult = reply(m, mci, e, TimeOuts.to_auth, getsasldata, NULL,
>> :                                                         ^~~~~~~~~~~
>
> Have you tried the patch I posted here?
>
> http://lists.freebsd.org/pipermail/freebsd-current/2013-March/040634.html
>
> If people feel this is the right approach, I am happy to commit it.  If
> people prefer to just shut up warnings, I am happy with that too.

Confirmed.  This fixes the build of usr.sbin/sendmail even without the
NO_WERROR.clang= option.

Thanks :-)