svn commit: r240938 - head/sys/net

[Konstantin Belousov]

On Wed, Sep 26, 2012 at 08:48:03AM -0400, Ed Maste wrote:
> On 26 September 2012 00:52, Konstantin Belousov <kostikbel at gmail.com> wrote:
> > On Tue, Sep 25, 2012 at 10:10:14PM +0000, Ed Maste wrote:
> >> Author: emaste
> >> Date: Tue Sep 25 22:10:14 2012
> >> New Revision: 240938
> >> URL: http://svn.freebsd.org/changeset/base/240938
> >>
> >> Log:
> >>   Avoid INVARIANTS panic destroying an in-use tap(4)
> >>
> >>   The requirement (implied by the KASSERT in tap_destroy) that the tap is
> >>   closed isn't valid; destroy_dev will block in devdrn while other threads
> >>   are in d_* functions.
> > Are you sure ?
> >
> > The device may be opened, but no threads could be in any cdevsw
> > methods. destroy_dev(9) only waits for threads to leave cdevsw methods,
> > and not for the close to happen.
> 
> My first approach mirrored if_tun, but jhb@ pointed out on IRC that
> any open devices will revert to dead_devsw so that future accesses
> will fail.

Yes, I do understand about the devfs part. My question is about the driver
readiness for destruction while in the open state.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20120926/b40638ff/attachment.pgp