svn commit: r240067 - head/sys/kern

Aleksandr Rybalko ray at dlink.ua
Tue Sep 4 08:11:26 UTC 2012


On Mon, 3 Sep 2012 20:02:08 +0300
Konstantin Belousov <kostikbel at gmail.com> wrote:

>> On Mon, Sep 03, 2012 at 09:09:08AM -0700, mdf at freebsd.org wrote:
>> > On Mon, Sep 3, 2012 at 1:52 AM, Aleksandr Rybalko
>> > <ray at freebsd.org> wrote:
>> > > Author: ray
>> > > Date: Mon Sep  3 08:52:05 2012
>> > > New Revision: 240067
>> > > URL: http://svn.freebsd.org/changeset/base/240067
>> > >
>> > > Log:
>> > >   Add kern.hintmode sysctl variable to show current state of
>> > > hints: 0 - loader hints in environment only;
>> > >   1 - static hints only
>> > >   2 - fallback mode (Dynamic KENV with fallback to kernel
>> > > environment) Add kern.hintmode write handler, accept only value
>> > > 2. That will switch static KENV to dynamic. So it will be
>> > > possible to change device hints.
>> > >
>> > >   Approved by:  adrian (mentor)
>> > >
>> > > Modified:
>> > >   head/sys/kern/subr_hints.c
>> > >
>> > > Modified: head/sys/kern/subr_hints.c
>> > > ==============================================================================
>> > > --- head/sys/kern/subr_hints.c  Mon Sep  3 07:18:24 2012
>> > > (r240066) +++ head/sys/kern/subr_hints.c  Mon Sep  3 08:52:05
>> > > 2012        (r240067) @@ -29,8 +29,10 @@ __FBSDID("$FreeBSD$");
>> > >
>> > >  #include <sys/param.h>
>> > >  #include <sys/lock.h>
>> > > +#include <sys/malloc.h>
>> > >  #include <sys/mutex.h>
>> > >  #include <sys/systm.h>
>> > > +#include <sys/sysctl.h>
>> > 
>> > Putting on my style-nazi hat.  sysctl comes before systm
>> > alphabetically.
>> Systm.h is very special, it normally comes as the second item in the
>> include list, right after param.h.

Just recheck, in that case there is indeed no requirement to swap
sysctl.h and systm.h.

Thanks Kostik!

Will fix my style(9)ability :)

WBW
-- 
Alexandr Rybalko <ray at dlink.ua> 
aka Alex RAY <ray at ddteam.net>


More information about the svn-src-all mailing list