svn commit: r236289 - head/usr.sbin/lpr/lpr

Eitan Adler eadler at FreeBSD.org
Wed May 30 04:08:30 UTC 2012


Author: eadler
Date: Wed May 30 04:08:29 2012
New Revision: 236289
URL: http://svn.freebsd.org/changeset/base/236289

Log:
  Relax security permissions on '.seq' file creation - the strict,
  but odd permissions resulted in a security alert from 110.neggrpperm
  
  PR:		kern/165533
  Submitted by:	Anton Shterenlikht <mexas at bristol.ac.uk>
  Submitted by:	J B <jb.1234abcd at gmail.com>
  Approved by:	cperciva
  MFC after:	1 week

Modified:
  head/usr.sbin/lpr/lpr/lpr.c

Modified: head/usr.sbin/lpr/lpr/lpr.c
==============================================================================
--- head/usr.sbin/lpr/lpr/lpr.c	Wed May 30 04:06:38 2012	(r236288)
+++ head/usr.sbin/lpr/lpr/lpr.c	Wed May 30 04:08:29 2012	(r236289)
@@ -846,7 +846,7 @@ mktemps(const struct printer *pp)
 
 	(void) snprintf(buf, sizeof(buf), "%s/.seq", pp->spool_dir);
 	seteuid(euid);
-	if ((fd = open(buf, O_RDWR|O_CREAT, 0661)) < 0) {
+	if ((fd = open(buf, O_RDWR|O_CREAT, 0664)) < 0) {
 		printf("%s: cannot create %s\n", progname, buf);
 		exit(1);
 	}


More information about the svn-src-all mailing list