svn commit: r235797 - head/contrib/gcc

Garrett Cooper yanegomi at gmail.com
Wed May 23 07:01:37 UTC 2012


On May 22, 2012, at 11:41 PM, Dimitry Andric <dim at FreeBSD.org> wrote:

> On 2012-05-22 23:07, mdf at FreeBSD.org wrote:
> ...
>> We run with the following at Isilon, which is somewhat bogus because
>> it allows a bit of sloppiness in types, but is also terribly
>> convenient since it means no casting on printf arguments is needed:
> 
> Please don't.  If you want to write portable code, use the (admittedly
> horrible) PRId64 macros instead.

Agreed, because the patch attached earlier disguises issues with signedness (for one) and I've seen some interesting bugs creep in because of issues like that, an it's painful cleaning up those problems later on (esp. considering that clang will replace gcc not too far down the line)...

Thanks,
-Garrett


More information about the svn-src-all mailing list