svn commit: r235771 - head/bin/expr

[Garrett Cooper]

On May 21, 2012, at 10:41 PM, Baptiste Daroussin wrote:

> On Mon, May 21, 2012 at 09:20:59PM -0700, Garrett Cooper wrote:
>> On Mon, May 21, 2012 at 8:01 PM, Kevin Lo <kevlo at freebsd.org> wrote:
>>> Author: kevlo
>>> Date: Tue May 22 03:01:54 2012
>>> New Revision: 235771
>>> URL: http://svn.freebsd.org/changeset/base/235771
>>> 
>>> Log:
>>>  Remove redundant declaration of yyparse
>>> 
>>>  Reported by:  tinderbox
>>> 
>>> Modified:
>>>  head/bin/expr/expr.y
>>> 
>>> Modified: head/bin/expr/expr.y
>>> ==============================================================================
>>> --- head/bin/expr/expr.y        Tue May 22 02:37:04 2012        (r235770)
>>> +++ head/bin/expr/expr.y        Tue May 22 03:01:54 2012        (r235771)
>>> @@ -74,7 +74,6 @@ int           to_integer(struct val *);
>>>  void           to_string(struct val *);
>>>  int            yyerror(const char *);
>>>  int            yylex(void);
>>> -int            yyparse(void);
>>> 
>>>  %}
>> 
>>    There are a lot more than just this unfortunately (I'm working on
>> a complete patchset).
>>    This breakage really makes me think that yacc isn't being built at
>> the right time or pathed properly in the build system.
> 
> The complete patch set is there:
> http://people.freebsd.org/~bapt/fix-after-yacc.diff
> (clang seems to not detect those redudant warning, while gcc complains)
> 
> I'm waiting for review before committing)
> 
> Thanks for this fix I'll remove it from my patchset

	Yeah, that looks about right (I was about 4/5 of the way there, but you beat me to the punch :)..).
Cheers!
-Garrett