svn commit: r235480 - in stable/9/sys: dev/usb geom geom/mountver i386/conf kern sys

Konstantin Belousov kostikbel at gmail.com
Tue May 15 18:28:01 UTC 2012


On Tue, May 15, 2012 at 05:21:47PM +0000, Andriy Gapon wrote:
> Author: avg
> Date: Tue May 15 17:21:46 2012
> New Revision: 235480
> URL: http://svn.freebsd.org/changeset/base/235480
> 
> Log:
>   MFC r230643: stop_scheduler -> td_stopsched
> Modified: stable/9/sys/sys/proc.h
> ==============================================================================
> --- stable/9/sys/sys/proc.h	Tue May 15 17:11:00 2012	(r235479)
> +++ stable/9/sys/sys/proc.h	Tue May 15 17:21:46 2012	(r235480)
> @@ -235,6 +235,7 @@ struct thread {
>  	short		td_locks;	/* (k) Count of non-spin locks. */
>  	short		td_rw_rlocks;	/* (k) Count of rwlock read locks. */
>  	short		td_lk_slocks;	/* (k) Count of lockmgr shared locks. */
> +	short		td_stopsched;	/* (k) Scheduler stopped. */
>  	struct turnstile *td_blocked;	/* (t) Lock thread is blocked on. */
>  	const char	*td_lockname;	/* (t) Name of lock blocked on. */
>  	LIST_HEAD(, turnstile) td_contested;	/* (q) Contested locks. */
> 
Did you verified that there is a gap between td_lk_slocks and td_blocked
an all tier-1 architectures large enough to adopt td_stopsched without
changing the layout of struct thread after the new member ?

If not, this breaks KBI.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20120515/db4e88b0/attachment.pgp


More information about the svn-src-all mailing list