svn commit: r235005 - head/usr.sbin/pc-sysinstall/backend

Doug Barton dougb at FreeBSD.org
Fri May 4 20:15:02 UTC 2012


On 05/04/2012 11:22 AM, Baptiste Daroussin wrote:
>>> > >   fetch -s "${FETCHFILE}" >${SIZEFILE}
>>> > >   SIZE="`cat ${SIZEFILE}`"
>>> > > -  SIZE="`expr ${SIZE} / 1024`"
>>> > > +  SIZE=$((SIZE/1024))
>> > 
>> > Bug; should be '$SIZE/'
> No this is perfectly valid

Yes, that works, but it's not our usual style. However, the point is
moot as that whole block should be reduced down to:

SIZE=$(( `fetch -s "${FETCHFILE}"` / 1024 ))

If SIZEFILE is needed elsewhere that's a different matter, but as it is
that's a hot mess.


More information about the svn-src-all mailing list