svn commit: r232748 - head/usr.bin/netstat

Dimitry Andric dim at FreeBSD.org
Fri Mar 9 20:50:16 UTC 2012


Author: dim
Date: Fri Mar  9 20:50:15 2012
New Revision: 232748
URL: http://svn.freebsd.org/changeset/base/232748

Log:
  After r232745, which makes sure __bswap16(), ntohs() and htons() return
  __uint16_t, we can partially undo r228668.
  
  Note the remark "Work around a clang false positive with format string
  warnings and ntohs macros (see LLVM PR 11313)" was actually incorrect.
  
  Before r232745, on some arches, the ntohs() macros did in fact return
  int, not uint16_t, so clang was right in warning about the %hu format
  string.
  
  MFC after:	2 weeks

Modified:
  head/usr.bin/netstat/Makefile

Modified: head/usr.bin/netstat/Makefile
==============================================================================
--- head/usr.bin/netstat/Makefile	Fri Mar  9 20:43:29 2012	(r232747)
+++ head/usr.bin/netstat/Makefile	Fri Mar  9 20:50:15 2012	(r232748)
@@ -8,9 +8,6 @@ SRCS=	if.c inet.c main.c mbuf.c mroute.c
 	unix.c atalk.c mroute6.c ipsec.c bpf.c pfkey.c sctp.c
 
 WARNS?=	3
-# XXX: Work around a clang false positive with format string warnings
-# and ntohs macros (see LLVM PR 11313).
-NO_WFORMAT.clang=
 CFLAGS+=-fno-strict-aliasing
 
 CFLAGS+=-DIPSEC


More information about the svn-src-all mailing list