svn commit: r232317 - in head: . sys/kern sys/sys

Mikolaj Golub trociny at freebsd.org
Thu Mar 1 06:38:03 UTC 2012


On Wed, 29 Feb 2012 23:44:47 +0000 Bjoern A. Zeeb wrote:

 BAZ> On 29. Feb 2012, at 21:38 , Mikolaj Golub wrote:

 >> Author: trociny
 >> Date: Wed Feb 29 21:38:31 2012
 >> New Revision: 232317
 >> URL: http://svn.freebsd.org/changeset/base/232317
 >> 
 >> Log:
 >>  Introduce VOP_UNP_BIND(), VOP_UNP_CONNECT(), and VOP_UNP_DETACH()
 >>  operations for setting and accessing vnode's v_socket field.
 >> 
 >>  The operations are necessary to implement proper unix socket handling
 >>  on layered file systems like nullfs(5).
 >> 
 >>  This change fixes the long standing issue with nullfs(5) being in that
 >>  unix sockets did not work between lower and upper layers: if we bound
 >>  to a socket on the lower layer we could connect only to the lower
 >>  path; if we bound to the upper layer we could connect only to the
 >>  upper path. The new behavior is one can connect to both the lower and
 >>  the upper paths regardless what layer path one binds to.

 BAZ> At this point I wonder if jhb has added (enough) spares with an earlier MFC of another change or whether we'll break thing again?

That is why I asked about this on arch@ and was waiting several days for
people opinion :-). The response I had was: do MFC if jhb does not have any
plans for the vop spares (and he does not).

I can change "MFC after" to 2 months or undef, and I will be fine with any
other solution proposed.

 >> 
 >>  PR:                kern/51583, kern/159663
 >>  Suggested by:        kib
 >>  Reviewed by:        arch
 >>  MFC after:        2 weeks

 BAZ> -- 
 BAZ> Bjoern A. Zeeb                                 You have to have visions!
 BAZ>    It does not matter how good you are. It matters what good you do!

-- 
Mikolaj Golub


More information about the svn-src-all mailing list