svn commit: r236759 - head/usr.bin/sort

Dimitry Andric dim at FreeBSD.org
Fri Jun 8 18:48:44 UTC 2012


On 2012-06-08 19:30, Gabor Kovesdan wrote:
> On 2012.06.08. 19:08, Dimitry Andric wrote:
...
>> -#define	UNUSED_ARG(A) do { A=A; } while(0)
>> +#define	UNUSED_ARG(A) do { (void)(A); } while(0)
> My fault, I should have fixed this. But what about this version? I think 
> it is more elegant and this is how it should have been done initially:

No worries, I just used the least disruptive way of fixing it.  Note
that it also only occurs specifically when you compile with -save-temps
or with ccache, which does preprocessing and compiling separately.

Your new diff looks good to me.  Though please attach diffs next time,
for some reason your mail client (or mine) badly mangled the tabs, and
it was tricky to apply. :)


More information about the svn-src-all mailing list