svn commit: r238182 - head/lib/libc/locale

Konstantin Belousov kostikbel at gmail.com
Fri Jul 6 21:24:01 UTC 2012


On Sat, Jul 07, 2012 at 12:15:29AM +0300, Konstantin Belousov wrote:
> On Fri, Jul 06, 2012 at 08:16:22PM +0000, David Chisnall wrote:
> > Author: theraven
> > Date: Fri Jul  6 20:16:22 2012
> > New Revision: 238182
> > URL: http://svn.freebsd.org/changeset/base/238182
> > 
> > Log:
> >   Restore the __collate_load_error global that was accidentally removed in the
> >   xlocale refactoring.
> >   
> I think this commit is wrong, or at least not complete.
> You failed to restore the actual export of the symbol in locale/Symbol.map.

I stay corrected: the symbol _is_ present in the Symbol.map, sorry. But
it is located in the private version definition, which was the reason
that I did not noticed it, and which changes the status of commit from
"incomplete" to "unneccessary". We do not guarantee anything about
private symbols.

Most likely, it is application error to link to this symbol. If application
use for it is legitimate, then the symbol shall be moved to FBSD_1.3
version.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20120706/1c47ba8e/attachment.pgp


More information about the svn-src-all mailing list