svn commit: r230393 - head/contrib/llvm/lib/Target/X86
Dimitry Andric
dim at FreeBSD.org
Fri Jan 20 19:18:12 UTC 2012
Author: dim
Date: Fri Jan 20 19:18:11 2012
New Revision: 230393
URL: http://svn.freebsd.org/changeset/base/230393
Log:
Pull in r148240 from upstream llvm trunk:
Make sure the non-SSE lowering for fences correctly clobbers EFLAGS.
PR11768.
In particular, this fixes segfaults during the build of devel/icu on
i386. The __sync_synchronize() builtin used for implementing icu's
internal barrier could lead to incorrect behaviour.
MFC after: 3 days
Modified:
head/contrib/llvm/lib/Target/X86/X86InstrCompiler.td
Modified: head/contrib/llvm/lib/Target/X86/X86InstrCompiler.td
==============================================================================
--- head/contrib/llvm/lib/Target/X86/X86InstrCompiler.td Fri Jan 20 18:55:56 2012 (r230392)
+++ head/contrib/llvm/lib/Target/X86/X86InstrCompiler.td Fri Jan 20 19:18:11 2012 (r230393)
@@ -533,7 +533,7 @@ def ATOMSWAP6432 : I<0, Pseudo, (outs GR
// Memory barriers
// TODO: Get this to fold the constant into the instruction.
-let isCodeGenOnly = 1 in
+let isCodeGenOnly = 1, Defs = [EFLAGS] in
def OR32mrLocked : I<0x09, MRMDestMem, (outs), (ins i32mem:$dst, GR32:$zero),
"lock\n\t"
"or{l}\t{$zero, $dst|$dst, $zero}",
More information about the svn-src-all
mailing list