svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog ypserv

Hiroki Sato hrs at FreeBSD.org
Tue Jan 17 21:00:00 UTC 2012


Eitan Adler <eadler at FreeBSD.org> wrote
  in <201112212027.pBLKRfPK084637 at svn.freebsd.org>:

ea> Author: eadler (ports committer)
ea> Date: Wed Dec 21 20:27:41 2011
ea> New Revision: 228790
ea> URL: http://svn.freebsd.org/changeset/base/228790
ea>
ea> Log:
ea>   - Remove extraneous null ptr deref checks
ea>   - Fix memory leak
ea>
ea>   Submitted by:	Slono Slono <slonoman2011 at yandex.ru>
ea>   Approved by:	jhb
ea>   MFC after:	1 week
ea>
ea> Modified:
ea>   head/usr.sbin/fwcontrol/fwcontrol.c
ea>   head/usr.sbin/newsyslog/newsyslog.c
ea>   head/usr.sbin/ypserv/yp_main.c

 I suspects you did not test ypserv after this change.  Freeing the
 pointer sname at the end of create_service() is completely wrong and
 probably people get the following error message when invoking ypserv:

  getaddrinfo(): servname not supported for ai_socktype

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20120117/0263149a/attachment.pgp


More information about the svn-src-all mailing list