svn commit: r230264 - head/sys/sys

Andre Oppermann andre at freebsd.org
Tue Jan 17 14:33:08 UTC 2012


On 17.01.2012 13:16, Gleb Smirnoff wrote:
> On Tue, Jan 17, 2012 at 12:13:37PM +0000, Gleb Smirnoff wrote:
> T>  Author: glebius
> T>  Date: Tue Jan 17 12:13:36 2012
> T>  New Revision: 230264
> T>  URL: http://svn.freebsd.org/changeset/base/230264
> T>
> T>  Log:
> T>    Provide a function m_get2() that allocates a minimal mbuf that
> T>    would fit specified size. Returned mbuf may be a single mbuf,
> T>    an mbuf with a cluster from packet zone, or an mbuf with jumbo
> T>    cluster of sufficient size.
>
> I am open to discussion on bikeshed color^W^W a better name for
> this function.

We already have m_getm2() which does the same for mbuf chains.

> I utilized it in pfsync, however there are several other places where
> it can be used instead of handrolled "if else if else" constructs.

Handrolled mbuf allocation isn't good.  Should be all in one place.

-- 
Andre


More information about the svn-src-all mailing list