svn commit: r229466 - head/usr.sbin/mptable

[Ronald Klop]

I don't know much about this code, but is chmod 0666 really wat is wanted  
here (and in the commits following this one)? It makes the file world  
writable. And that smells funny. :-)

Ronald.

On Wed, 04 Jan 2012 08:04:44 +0100, Pawel Jakub Dawidek <pjd at freebsd.org>  
wrote:

> Author: pjd
> Date: Wed Jan  4 07:04:43 2012
> New Revision: 229466
> URL: http://svn.freebsd.org/changeset/base/229466
>
> Log:
>   Add an missing argument to open(2). If O_CREAT flag is specified,
>   file permission has to be specified as well.
>
> Modified:
>   head/usr.sbin/mptable/mptable.c
>
> Modified: head/usr.sbin/mptable/mptable.c
> ==============================================================================
> --- head/usr.sbin/mptable/mptable.c	Wed Jan  4 07:01:23 2012	(r229465)
> +++ head/usr.sbin/mptable/mptable.c	Wed Jan  4 07:04:43 2012	(r229466)
> @@ -828,7 +828,7 @@ MPConfigTableHeader( u_int32_t pap )
>      int		ofd;
>      u_char	dumpbuf[ 4096 ];
> -    ofd = open( "/tmp/mpdump", O_CREAT | O_RDWR );
> +    ofd = open( "/tmp/mpdump", O_CREAT | O_RDWR, 0666 );
>      seekEntry( paddr );
>      readEntry( dumpbuf, 1024 );
>      write( ofd, dumpbuf, 1024 );
> _______________________________________________
> svn-src-all at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"