svn commit: r232301 - head/sys/fs/nullfs

Konstantin Belousov kib at FreeBSD.org
Wed Feb 29 15:09:20 UTC 2012


Author: kib
Date: Wed Feb 29 15:09:20 2012
New Revision: 232301
URL: http://svn.freebsd.org/changeset/base/232301

Log:
  Always request exclusive lock for the lower vnode in nullfs_vget().
  The null_nodeget() requires exclusive lock on lowervp to be able to
  insmntque() new vnode.
  
  Reported by:	rea
  Tested by:	pho
  MFC after:	1 week

Modified:
  head/sys/fs/nullfs/null_vfsops.c

Modified: head/sys/fs/nullfs/null_vfsops.c
==============================================================================
--- head/sys/fs/nullfs/null_vfsops.c	Wed Feb 29 15:06:40 2012	(r232300)
+++ head/sys/fs/nullfs/null_vfsops.c	Wed Feb 29 15:09:20 2012	(r232301)
@@ -312,6 +312,12 @@ nullfs_vget(mp, ino, flags, vpp)
 	struct vnode **vpp;
 {
 	int error;
+
+	KASSERT((flags & LK_TYPE_MASK) != 0,
+	    ("nullfs_vget: no lock requested"));
+	flags &= ~LK_TYPE_MASK;
+	flags |= LK_EXCLUSIVE;
+
 	error = VFS_VGET(MOUNTTONULLMOUNT(mp)->nullm_vfs, ino, flags, vpp);
 	if (error)
 		return (error);


More information about the svn-src-all mailing list