svn commit: r232072 - head/usr.bin/kdump

John Baldwin jhb at freebsd.org
Fri Feb 24 20:31:13 UTC 2012


On Friday, February 24, 2012 12:57:23 pm Bruce Evans wrote:
> On Thu, 23 Feb 2012, John Baldwin wrote:
> 
> > Log:
> >  Pretty-print the advice constants passed to posix_fadvise(2).
> 
> > Modified: head/usr.bin/kdump/kdump.c
> > 
==============================================================================
> > --- head/usr.bin/kdump/kdump.c	Thu Feb 23 21:07:16 2012	(r232071)
> > +++ head/usr.bin/kdump/kdump.c	Thu Feb 23 21:08:21 2012	(r232072)
> > @@ -1014,6 +1014,15 @@ ktrsyscall(struct ktr_syscall *ktr, u_in
> > 				}
> > 				capname(arg);
> > 				break;
> > +			case SYS_posix_fadvise:
> > +				print_number(ip,narg,c);
> > +				print_number(ip,narg,c);
> > +				print_number(ip,narg,c);
> > ...
> 
> Any chance of prettyprinting the sources too?  The (macro) definition
> was already uglyprinted, but kdump is fairly KNF-conformant (unlike
> truss), and doesn't use uglyprinting when invoking print_number()
> except for here.

Oops, I originally did this on 8 where it still has the wrong style.
I'll fix.

-- 
John Baldwin


More information about the svn-src-all mailing list