svn commit: r239334 - head/sys/netinet

Randall Stewart rrs at FreeBSD.org
Thu Aug 16 17:55:17 UTC 2012


Author: rrs
Date: Thu Aug 16 17:55:16 2012
New Revision: 239334
URL: http://svn.freebsd.org/changeset/base/239334

Log:
  Its never a good idea to double free the same
  address.
  
  MFC after:	1 week (after the other commits ahead of this gets MFC'd)

Modified:
  head/sys/netinet/in.c

Modified: head/sys/netinet/in.c
==============================================================================
--- head/sys/netinet/in.c	Thu Aug 16 17:27:11 2012	(r239333)
+++ head/sys/netinet/in.c	Thu Aug 16 17:55:16 2012	(r239334)
@@ -573,7 +573,7 @@ in_control(struct socket *so, u_long cmd
 	}
 	TAILQ_REMOVE(&ifp->if_addrhead, &ia->ia_ifa, ifa_link);
 	IF_ADDR_WUNLOCK(ifp);
-	ifa_free(&ia->ia_ifa);				/* if_addrhead */
+/*	ifa_free(&ia->ia_ifa);	- Double free?? */	/* if_addrhead */
 
 	IN_IFADDR_WLOCK();
 	TAILQ_REMOVE(&V_in_ifaddrhead, ia, ia_link);


More information about the svn-src-all mailing list