svn commit: r225458 - in stable/8/sys: dev/usb dev/usb/quirk dev/usb/storage sys

[Kostik Belousov]

On Sat, Sep 10, 2011 at 11:21:00AM +0000, Bjoern A. Zeeb wrote:
> 
> On Sep 10, 2011, at 10:54 AM, Robert Watson wrote:
> 
> > On Fri, 9 Sep 2011, Hans Petter Selasky wrote:
> > 
> >> Log:
> >> MFC r225350 and r225400:
> >> 
> >> This patch adds automatic detection of USB mass storage devices
> >> which does not support the no synchronize cache SCSI command.
> >> 
> >> The __FreeBSD_version version macro has been bumped and
> >> external kernel modules needs to be recompiled after
> >> this patch.
> >> 
> >> PR:	usb/160299
> > 
> > For most other classes of hardware device driver framework KPIs -- especially things like PCI bus attachment, busdma, CAM, ifnet, and GEOM frameworks, our MFC rules would strictly disallow this sort of change, on the grounds that it is our KBI policy that we not break common classes of third-party device drivers (i.e., require them to be recompiled).  My suspicion is that we should be applying the same rules to the USB framework -- however, I don't know if we have any third-party USB device drivers?
> > 
> > (If we do, then this change should not have been MFC'd.)
> 
> We do have FreeBSD consumers with private USB drivers, yes.

It seems that most of the damage can be mitigated by placing the added
fields at the end of the structures, at least for stable/8.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20110910/68a4448d/attachment.pgp