svn commit: r226947 - in head/sys: dev/esp sparc64/sbus
julian at freebsd.org
Mon Oct 31 05:11:19 UTC 2011
On 10/30/11 9:25 PM, Alexey Dokuchaev wrote:
> On Sun, Oct 30, 2011 at 09:17:42PM +0000, Marius Strobl wrote:
>> Author: marius
>> Date: Sun Oct 30 21:17:42 2011
>> New Revision: 226947
>> URL: http://svn.freebsd.org/changeset/base/226947
>> - Use device_t rather than the NetBSDish struct device.
> Hmm, I though that style(9) advises against this practice:
> Avoid using typedefs for structure types. Typedefs are problematic
> because they do not properly hide their underlying type; [...]
> When convention requires a typedef, make its name match the struct tag.
> Avoid typedefs ending in _t, except as specified in Standard C or by
> Does these rules not apply for struct device for some reason?
I agree we should be trying to get rid of the blah_t horrors. I think
this went the wrong direction.
More information about the svn-src-all