svn commit: r226553 - in head/sys: boot/zfs cddl/boot/zfs

Andriy Gapon avg at
Thu Oct 20 07:21:29 UTC 2011

on 20/10/2011 02:44 Pawel Jakub Dawidek said the following:
> Author: pjd
> Date: Wed Oct 19 23:44:38 2011
> New Revision: 226553
> URL:
> Log:
>   Always pass data size for checksum verification function, as using
>   physical block size declared in bp may not always be what we want.
>   For example in case of gang block header physical block size declared
>   in bp is much larger than SPA_GANGBLOCKSIZE (512 bytes) and checksum
>   calculation failed. This bug could lead to accessing unallocated
>   memory and resets/failures during boot.
>   MFC after:	3 days

I believe that this change is going in the wrong direction.  I'd rather prefer
that we decreased number of parameters :-)  Se my other email.

Besides I do not see where we currently really verify checksum of a re-assembled
gang block.

Andriy Gapon

More information about the svn-src-all mailing list