svn commit: r228099 - head/usr.bin/grep

[Xin LI]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 11/28/11 15:58, Gábor Kövesdán wrote:
> On 2011.11.28. 21:22, Xin LI wrote:
>> This is useful but could be confusing since xzgrep's behavior
>> could be different from zgrep.
> What do you refer to exactly? That zgrep is GNU grep and xzgrep is
> BSD grep? I acknowledge that this is not documented but xzgrep is
> a

Yes.

> non-standard addition so personally think it is acceptable.
> Someone called my attention to the archivers/xz port that had a
> wrapper script for grep, callled xzgrep. This was installed with
> the port but is not installed in base any more so I got the
> suggestion to implement it in BSD grep and I think it is a better
> idea than a wrapper script and it was easy to support. So with this
> change, this functionality can be used again w/o installing the
> port although it is not documented.

I'm not quite convinced but your reasoning do have something so let's
keep it as-is for now, at least.  Eventually we would have the two
behave the same so it would not even be a problem for the future.

>> Another topic would be ObsoleteFiles.inc (or 
>> OptionalObsoleteFiles.inc) needs to be updated for this as well.
> I don't think they should be updated. From now on, xzgrep and such
> are always created and they always point to BSD grep, which can be 
> /usr/bin/grep or /usr/bin/bsdgrep depending on WITH_BSD_GREP. But
> they always exist and point to one or another. I cannot think of
> any case when they should be removed.

Ah ok, I thought there was an option to disable building of bsdgrep
but I were wrong here.  Sorry for the noise.

Cheers,
- -- 
Xin LI <delphij at delphij.net>	https://www.delphij.net/
FreeBSD - The Power to Serve!		Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iQEcBAEBCAAGBQJO1Cg9AAoJEATO+BI/yjfB+yAIAK7v7GJNaBIa25TFnbw4siRb
c7LZ0VOp2W3i+QlmzhoWDFkW4SLedol93dKiD5ymDAhTrgaN/KS1ul2vb3kYrrr7
ZblinAfb1/NSWEtmQaUqZffExT1wBpGhLPRKm979Mn6BMHgaV5f+PqKw36uTwuqA
9O8AFZnEsplkf5FI71758yXugS48DzJnaAD/7/jC7v/l2GNHs7l+HMTBOS50/I/2
mLX98uerCYvIZ9U51Le4J9WI62oN9HcmVqTG0brUvVYCyEtL7Cjf8MrYE3b1m16l
q5YU1uyTMQPTpQhIlRGUe80hcNN0kROpjR5hez0i/2gKXp3BSKVPyB0peTC34n0=
=6v/S
-----END PGP SIGNATURE-----