svn commit: r227473 - head/sbin/geom/class/multipath

Pawel Jakub Dawidek pjd at FreeBSD.org
Sun Nov 13 22:09:13 UTC 2011


On Sat, Nov 12, 2011 at 12:16:23PM -0800, Garrett Cooper wrote:
> On Sat, Nov 12, 2011 at 12:01 PM, Alexander Motin <mav at freebsd.org> wrote:
> > Author: mav
> > Date: Sat Nov 12 20:01:30 2011
> > New Revision: 227473
> > URL: http://svn.freebsd.org/changeset/base/227473
> >
> > Log:
> >  Fix build on some archs after r227464.
> >
> > Modified:
> >  head/sbin/geom/class/multipath/geom_multipath.c
> >
> > Modified: head/sbin/geom/class/multipath/geom_multipath.c
> > ==============================================================================
> > --- head/sbin/geom/class/multipath/geom_multipath.c     Sat Nov 12 19:55:48 2011        (r227472)
> > +++ head/sbin/geom/class/multipath/geom_multipath.c     Sat Nov 12 20:01:30 2011        (r227473)
> > @@ -133,7 +133,8 @@ mp_label(struct gctl_req *req)
> >        uint8_t *sector, *rsector;
> >        char *ptr;
> >        uuid_t uuid;
> > -       uint32_t secsize = 0, ssize, status;
> > +       ssize_t secsize = 0, ssize;
> > +       uint32_t status;
> >        const char *name, *name2, *mpname;
> >        int error, i, nargs, fd;
> >
> > @@ -161,8 +162,8 @@ mp_label(struct gctl_req *req)
> >                        disksize = msize;
> >                } else {
> >                        if (secsize != ssize) {
> > -                               gctl_error(req, "%s sector size %u different.",
> > -                                   name, ssize);
> > +                               gctl_error(req, "%s sector size %ju different.",
> > +                                   name, (intmax_t)ssize);
> 
> Shouldn't that be uintmax_t, not intmax_t ?

No, ssize_t is signed. Although the best would be to use %zd for
ssize_t.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://yomoli.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20111113/66fcfcdb/attachment.pgp


More information about the svn-src-all mailing list