svn commit: r221972 - head/sys/geom/part

[Warner Losh]

After carefully reviewing this code, we need to have it be *OFF* by default.  It should also explain *WHY* it is rejecting the partition.  It isn't clear to me at all that this is even useful.  While different than Marcel's warnings, I think we need to take a very cautious approach here.  Where was this even talked about before the fact?  It seems like a fairly radical enforcement action to just spring on people, especially now in light of it having so many false positives.

Warner

On May 22, 2011, at 7:03 AM, Adrian Chadd wrote:

> This also bit me on embedded platform stuff.
> 
> Is it possible to disable this by default for now and have it just warn loudly?
> And/or hide the default value behind a kernel configuration variable
> so we can disable it
> (but still get the warnings) for now?
> 
> Thanks,
> 
> 
> Adrian
> 
> On 22 May 2011 17:33, Stefan Farfeleder <stefanf at freebsd.org> wrote:
>> On Sun, May 15, 2011 at 08:03:55PM +0000, Andrey V. Elsukov wrote:
>>> Author: ae
>>> Date: Sun May 15 20:03:54 2011
>>> New Revision: 221972
>>> URL: http://svn.freebsd.org/changeset/base/221972
>>> 
>>> Log:
>>>   Add a sysctl kern.geom.part.check_integrity for those who has corrupt
>>>   partition tables and lost an ability to boot after r221788.
>>>   Also unhide an error message from bootverbose, this would help to
>>>   easier determine the problem.
>> 
>> So, what's the point of this check? It breaks mounting of all my USB
>> drives.  Everyone now has to set this sysctl?
>> 
>> da0 at umass-sim0 bus 0 scbus6 target 0 lun 0
>> da0: <Kingston DT 101 G2 PMAP> Removable Direct Access SCSI-0 device
>> da0: 40.000MB/s transfers
>> da0: 15304MB (31342592 512 byte sectors: 255H 63S/T 1950C)
>> GEOM_PART: integrity check failed (da0, MBR)
>> 
>> Stefan
>> 
> 
>