svn commit: r219578 - head/etc

[Warner Losh]

On 03/12/2011 16:08, Jilles Tjoelker wrote:
> On Sat, Mar 12, 2011 at 09:13:08PM +0000, Doug Barton wrote:
>> Author: dougb
>> Date: Sat Mar 12 21:13:08 2011
>> New Revision: 219578
>> URL: http://svn.freebsd.org/changeset/base/219578
>> Log:
>>    Use the allexport option in load_rc_config() in order to avoid having
>>    to repeatedly read the conf files. Depending on what is enabled the
>>    files are being read anywhere from 15, 30, or more times currently.
>>    By loading the values in the environment this is reduced to 1, with
>>    perhaps a couple more, again depending on what is enabled.
> I wonder if it is a good idea to pollute the environment of many daemons
> with this. Although sshd and cron clean it up, there is at least one
> daemon that passes the environment on. One of those is devd. While that
> saves four /etc/rc.conf reads on my minimalistic 9-current VM, it
> implies that devd must be restarted to pick up changes to /etc/rc.conf.
> That seems a POLA violation.

devd shouldn't be passing this to its children.  imho, devd should be 
fixed to be more robust.

Warner