svn commit: r216967 - head/usr.sbin/rtprio

Garrett Cooper yanegomi at gmail.com
Tue Jan 4 18:30:46 UTC 2011


On Jan 4, 2011, at 10:22 AM, John Baldwin wrote:

> On Tuesday, January 04, 2011 12:41:51 pm Garrett Cooper wrote:
>> On Tue, Jan 4, 2011 at 9:27 AM, Konstantin Belousov <kib at freebsd.org> wrote:
>>> Author: kib
>>> Date: Tue Jan  4 17:27:17 2011
>>> New Revision: 216967
>>> URL: http://svn.freebsd.org/changeset/base/216967
>>> 
>>> Log:
>>> Use errx() instead of err() in parseint. There is usually no interesting
>>> information in errno.
>>> 
>>> Noted by:     Garrett Cooper <yanegomi gmail com>
>>> MFC after:    1 week
>> 
>> Someday it would be nice if we could have one standard / libraritized
>> set of functions that properly handle overflow and all that good stuff
>> (as bde has suggested to me elsewhere), but this is good enough for
>> today.
> 
> strtonum(3)?

	bde said (back in 11/15):

"It is good to fix the blind truncation, but overflow is never graceful.

I will review the patch for errors like the ones in corresponding user
code (dd get_num(), strtonum(), expand_number()...  get_num() is almost
OK, but the newer more public APIs are broken as designed)."

	So there's some concern that he has with those APIs still.. the fact that I was trying to use a similar API to parse numbers in strings in the kernel (strtoq in tunable work) didn't make things any better unfortunately.
Thanks,
-Garrett


More information about the svn-src-all mailing list