svn commit: r212804 - head/sys/boot/zfs

Stefan Farfeleder stefanf at FreeBSD.org
Sat Sep 18 11:45:10 UTC 2010


Um, was the change from 32 to 31 deliberate?

On Fri, Sep 17, 2010 at 10:51:45PM +0000, Pawel Jakub Dawidek wrote:
> Author: pjd
> Date: Fri Sep 17 22:51:45 2010
> New Revision: 212804
> URL: http://svn.freebsd.org/changeset/base/212804
> 
> Log:
>   Remove magic value.
> 
> Modified:
>   head/sys/boot/zfs/zfs.c
> 
> Modified: head/sys/boot/zfs/zfs.c
> ==============================================================================
> --- head/sys/boot/zfs/zfs.c	Fri Sep 17 22:05:27 2010	(r212803)
> +++ head/sys/boot/zfs/zfs.c	Fri Sep 17 22:51:45 2010	(r212804)
> @@ -45,6 +45,8 @@ __FBSDID("$FreeBSD$");
>  
>  #include "zfsimpl.c"
>  
> +#define	MAXBDDEV	31
> +
>  static int	zfs_open(const char *path, struct open_file *f);
>  static int	zfs_write(struct open_file *f, void *buf, size_t size, size_t *resid);
>  static int	zfs_close(struct open_file *f);
> @@ -402,7 +404,7 @@ zfs_dev_init(void) 
>  	 * diskN, diskNpM or diskNsM.
>  	 */
>  	zfs_init();
> -	for (unit = 0; unit < 32 /* XXX */; unit++) {
> +	for (unit = 0; unit < MAXBDDEV; unit++) {
>  		sprintf(devname, "disk%d:", unit);
>  		fd = open(devname, O_RDONLY);
>  		if (fd == -1)
> 


More information about the svn-src-all mailing list