svn commit: r212647 - head/sys/sys

Andriy Gapon avg at freebsd.org
Wed Sep 15 16:42:44 UTC 2010


on 15/09/2010 19:30 Andriy Gapon said the following:
> SET_DECLARE would expand to exactly those two lines.
> I am not sure why comment even said that it's impossible to use SET_DECLARE(),
> perhaps previously it used to expand to something bigger?

Having said that, I am not sure if it makes logical sense to use SET_DECLARE() in
pcpu.h.  Family of SET_* macros seems to be geared towards sets that contain
arrays of identical items (e.g. see SET_ITEM, SET_COUNT).  set_pcpu reserves space
for items of various types and sizes.  So I am not sure if using any SET_* macros
would not be confusing in the future.

What do you think?


-- 
Andriy Gapon


More information about the svn-src-all mailing list