svn commit: r212593 - head/sys/mips/mips

Neel Natu neel at FreeBSD.org
Tue Sep 14 01:48:01 UTC 2010


Author: neel
Date: Tue Sep 14 01:48:01 2010
New Revision: 212593
URL: http://svn.freebsd.org/changeset/base/212593

Log:
  Port r212559 to mips.
  
  Do not explicitly enable interrupts in smp_init_secondary() because it
  renders any spinlock protected code after that point to run with
  interrupts enabled. This is because the processor is executing in the
  context of idlethread whose 'md_spinlock_count' is already set to 1.
  
  Instead just let sched_throw() re-enable interrupts when it releases
  the spinlock.
  
  The original powerpc commit log for r212559 is available here:
  http://svn.freebsd.org/viewvc/base?view=revision&revision=212559

Modified:
  head/sys/mips/mips/mp_machdep.c

Modified: head/sys/mips/mips/mp_machdep.c
==============================================================================
--- head/sys/mips/mips/mp_machdep.c	Tue Sep 14 01:40:59 2010	(r212592)
+++ head/sys/mips/mips/mp_machdep.c	Tue Sep 14 01:48:01 2010	(r212593)
@@ -310,8 +310,6 @@ smp_init_secondary(u_int32_t cpuid)
 	while (smp_started == 0)
 		; /* nothing */
 
-	intr_enable();
-
 	/* Start per-CPU event timers. */
 	cpu_initclocks_ap();
 


More information about the svn-src-all mailing list