svn commit: r212160 - in head/sys: cam/ata cam/scsi cddl/contrib/opensolaris/uts/common/fs/zfs geom geom/sched kern sys

[Pawel Jakub Dawidek]

On Thu, Sep 02, 2010 at 04:07:36PM -0600, Justin T. Gibbs wrote:
>  On 9/2/2010 3:39 PM, Pawel Jakub Dawidek wrote:
> > Don't you think it would be better to set the flag from within
> > g_io_request()? This way every BIO_FLUSH consumer doesn't have to
> > remember to set it. Or am I missing something?
> 
> I don't feel strongly one way or the other, but I thought that
> g_io_request()'s job was to execute the request and to test invariants,
> not to set policy.  Perhaps I misinterpreted it's role.

Does BIO_FLUSH make sense without BIO_ORDERED? My understanding is that
it doesn't. But we still want BIO_ORDERED for use with BIO_WRITE for
write barriers without cache flushing.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20100903/7861382c/attachment.pgp