svn commit: r212160 - in head/sys: cam/ata cam/scsi cddl/contrib/opensolaris/uts/common/fs/zfs geom geom/sched kern sys

Justin T. Gibbs gibbs at FreeBSD.org
Thu Sep 2 22:18:05 UTC 2010


 On 9/2/2010 3:39 PM, Pawel Jakub Dawidek wrote:
> On Thu, Sep 02, 2010 at 07:40:28PM +0000, Justin T. Gibbs wrote:
>> Author: gibbs
>> Date: Thu Sep 2 19:40:28 2010
>> New Revision: 212160
>> URL: http://svn.freebsd.org/changeset/base/212160
>>
>> Log:
>> Correct bioq_disksort so that bioq_insert_tail() offers barrier semantic.

...

>> sys/geom/geom_io.c
>> Mark bios with the BIO_FLUSH command as BIO_ORDERED.
> [...]
>
> Don't you think it would be better to set the flag from within
> g_io_request()? This way every BIO_FLUSH consumer doesn't have to
> remember to set it. Or am I missing something?

I don't feel strongly one way or the other, but I thought that
g_io_request()'s job was to execute the request and to test invariants,
not to set policy.  Perhaps I misinterpreted it's role.

--
Justin



More information about the svn-src-all mailing list