svn commit: r214409 - head/sys/kern

Garrett Cooper gcooper at FreeBSD.org
Thu Oct 28 00:52:36 UTC 2010


On Wed, Oct 27, 2010 at 9:22 AM, Andriy Gapon <avg at freebsd.org> wrote:
>
> [patch attachment was lost]

Ugh... Mailman hates me I guess :(...

> on 27/10/2010 19:07 Garrett Cooper said the following:
>>     How about this patch? I implemented this as a readonly tunable and
>
> I don't think that it's correct to call it a tunable or use CTLFLAG_RDTUN.
> As I understand it is a read-only sysctl.

Converted to CTLFLAG_RD.

>> sysconf tunable, because (AFAIK) the value that is being tested
>> shouldn't change during runtime after the system has been booted up,
>> and figuring that the value wasn't going to change it was better to
>> lose 4/8 bytes on the kernel stack instead of having to recompute the
>> value every time in a function call, with the associated lost heap /
>> stack memory in the process, as the assumption is that this libcall
>> was going to be called frequently by some programs.

Thanks!
-Garrett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cpuset_t-size-sysctl-and-sysconf-value.patch
Type: text/x-patch
Size: 1759 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20101028/1172cc9f/cpuset_t-size-sysctl-and-sysconf-value.bin


More information about the svn-src-all mailing list