svn commit: r213918 - head/sys/x86/isa
Andriy Gapon
avg at FreeBSD.org
Sat Oct 16 10:45:36 UTC 2010
Author: avg
Date: Sat Oct 16 10:45:36 2010
New Revision: 213918
URL: http://svn.freebsd.org/changeset/base/213918
Log:
atrtc: remove (pre-)historic check of RTC NVRAM at address 0x0e
Old scrolls tell that once upon a time IBM AT BIOS was known to put some
useful system diagnostic information into RTC NVRAM. It is not really
known if and for how long PC BIOSes followed that convention, but I
believe that many, if not all, modern BIOSes do not do that any more
(not mentioning other types of x86 firmware).
Some diagnostic bits don't even make any sense any longer.
The check results in confusing messages upon boot on some systems.
So I am removing it.
Discussed with: bde, jhb, mav
MFC after: 3 weeks
Modified:
head/sys/x86/isa/atrtc.c
Modified: head/sys/x86/isa/atrtc.c
==============================================================================
--- head/sys/x86/isa/atrtc.c Sat Oct 16 09:46:03 2010 (r213917)
+++ head/sys/x86/isa/atrtc.c Sat Oct 16 10:45:36 2010 (r213918)
@@ -242,15 +242,12 @@ atrtc_attach(device_t dev)
{
struct atrtc_softc *sc;
u_long s;
- int i, diag;
+ int i;
sc = device_get_softc(dev);
if (!(sc->port_res = bus_alloc_resource(dev, SYS_RES_IOPORT,
&sc->port_rid, IO_RTC, IO_RTC + 1, 2, RF_ACTIVE)))
device_printf(dev,"Warning: Couldn't map I/O.\n");
- diag = rtcin(RTC_DIAG);
- if (diag != 0)
- printf("RTC BIOS diagnostic error %b\n", diag, RTCDG_BITS);
atrtc_start();
clock_register(dev, 1000000);
bzero(&sc->et, sizeof(struct eventtimer));
More information about the svn-src-all
mailing list