svn commit: r215129 - in head: contrib/compiler-rt/lib lib/libcompiler_rt

Ed Schouten ed at FreeBSD.org
Thu Nov 11 16:53:25 UTC 2010


Author: ed
Date: Thu Nov 11 16:53:25 2010
New Revision: 215129
URL: http://svn.freebsd.org/changeset/base/215129

Log:
  Set symbol visibility to hidden.
  
  Not doing so may cause all sorts of random libraries to expose
  libcompiler_rt's functions, which should of course not be done.
  
  Discussed with:	kan, kib

Modified:
  head/contrib/compiler-rt/lib/assembly.h
  head/lib/libcompiler_rt/Makefile

Modified: head/contrib/compiler-rt/lib/assembly.h
==============================================================================
--- head/contrib/compiler-rt/lib/assembly.h	Thu Nov 11 16:06:47 2010	(r215128)
+++ head/contrib/compiler-rt/lib/assembly.h	Thu Nov 11 16:53:25 2010	(r215129)
@@ -33,7 +33,7 @@
 #ifdef VISIBILITY_HIDDEN
 #define DEFINE_COMPILERRT_FUNCTION(name) \
   .globl SYMBOL_NAME(name) SEPARATOR     \
-  .private_extern SYMBOL_NAME(name) SEPARATOR    \
+  .hidden SYMBOL_NAME(name) SEPARATOR    \
   SYMBOL_NAME(name):
 #else
 #define DEFINE_COMPILERRT_FUNCTION(name) \
@@ -43,12 +43,12 @@
 
 #define DEFINE_COMPILERRT_PRIVATE_FUNCTION(name) \
   .globl SYMBOL_NAME(name) SEPARATOR             \
-  .private_extern SYMBOL_NAME(name) SEPARATOR    \
+  .hidden SYMBOL_NAME(name) SEPARATOR    \
   SYMBOL_NAME(name):
 
 #define DEFINE_COMPILERRT_PRIVATE_FUNCTION_UNMANGLED(name) \
   .globl name SEPARATOR             \
-  .private_extern name SEPARATOR    \
+  .hidden name SEPARATOR    \
   name:
 
 #endif /* COMPILERRT_ASSEMBLY_H */

Modified: head/lib/libcompiler_rt/Makefile
==============================================================================
--- head/lib/libcompiler_rt/Makefile	Thu Nov 11 16:06:47 2010	(r215128)
+++ head/lib/libcompiler_rt/Makefile	Thu Nov 11 16:53:25 2010	(r215129)
@@ -6,7 +6,7 @@ LIB=	compiler_rt
 NO_PIC=
 WARNS?=	2
 
-CFLAGS+=${PICFLAG}
+CFLAGS+=${PICFLAG} -fvisibility=hidden -DVISIBILITY_HIDDEN
 
 .if ${MACHINE_CPUARCH} == "amd64"
 CRTARCH=x86_64


More information about the svn-src-all mailing list