svn commit: r208671 - head/sys/fs/udf

Andriy Gapon avg at FreeBSD.org
Mon May 31 09:08:44 UTC 2010


Author: avg
Date: Mon May 31 09:08:44 2010
New Revision: 208671
URL: http://svn.freebsd.org/changeset/base/208671

Log:
  udf_readlink: fix malloc call with uninitialized size parameter
  
  Found by:	clang static analyzer
  MFC after:	4 days

Modified:
  head/sys/fs/udf/udf_vnops.c

Modified: head/sys/fs/udf/udf_vnops.c
==============================================================================
--- head/sys/fs/udf/udf_vnops.c	Mon May 31 09:07:23 2010	(r208670)
+++ head/sys/fs/udf/udf_vnops.c	Mon May 31 09:08:44 2010	(r208671)
@@ -904,9 +904,9 @@ udf_readlink(struct vop_readlink_args *a
 	vp = ap->a_vp;
 	node = VTON(vp);
 	len = le64toh(node->fentry->inf_len);
+	iov[0].iov_len = len;
 	buf = malloc(iov[0].iov_len, M_DEVBUF, M_WAITOK);
 	iov[0].iov_base = buf;
-	iov[0].iov_len = len;
 	uio.uio_iov = iov;
 	uio.uio_iovcnt = 1;
 	uio.uio_offset = 0;


More information about the svn-src-all mailing list