svn commit: r207612 - head/usr.sbin/mergemaster

Alexander Leidinger Alexander at Leidinger.net
Tue May 4 14:46:06 UTC 2010


Quoting Norikatsu Shigemura <nork at FreeBSD.org> (from Tue, 4 May 2010  
23:22:46 +0900):

> Hi netchild.
>
> On Tue, 04 May 2010 16:02:55 +0200
> Alexander Leidinger <Alexander at leidinger.net> wrote:
>> > URL: http://svn.freebsd.org/changeset/base/207612
>> > Log:
>> >   Add support run services_mkdb(8).
>> Shouldn't this (and similar messages) only be done if there is a
>> corresponding DB file?
>> Everything is working just fine without the DB files, and the
>> man-pages only recommend to create DB files for performance reasons.
>> By default the DB files are not created, and as such it looks a bit
>> strange to tell to "make sure" to create the DB file(s).
>
> 	My first patch has a test code '[ -f /var/db/services.db ] &&',
> 	However, as the result, I discussed with dougb, he said that
> 	existing /var/db/services.db is harmless.  So I don't have any
> 	objection, and remove a test code.

I do not complain about your patch, you just had the bad luck that I  
noticed an extension of something which I think is not user friendly.  
I just used your commit to tell Doug (and others) about it.

I would print such a message only (for login.conf, services or  
whatever), if the DB file exists. Because if it exists, not updating  
the DB file is harmful (it does not contain what people would expect).  
If the file does not exist, there is nothing to do. The user does not  
want or does not know how to use this feature, so do not tell him to  
do or use something he doesn't want or doesn't understand (lack of  
knowledge, not lack of capability).

Bye,
Alexander.

-- 
Sometime in 1993 NANCY SINATRA will lead a BLOODLESS COUP on GUAM!!

http://www.Leidinger.net    Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org       netchild @ FreeBSD.org  : PGP ID = 72077137


More information about the svn-src-all mailing list