svn commit: r205104 - in head/sys: dev/xen/netback netinet
Robert N. M. Watson
rwatson at FreeBSD.org
Sat Mar 13 13:53:39 UTC 2010
On Mar 13, 2010, at 1:50 PM, Randall Stewart wrote:
> did not think of that.. we COULD possible do it another way.. a bit harder
> but possible.. i.e. have the delayed sack code actually look into
> the mbufs and see if its ipv4 or ipv6.. I thought about doing it
> that way but it takes more cycles ;-o
> I could refactor that this way if you want... it would mean a few more de-ref's and
> looking to see if its a v4 or v6 packet and then doing the proper offset...
> not to bad but awkward ;-0
Well, I think what I was trying to get across more is that this change is OK to merge, but only because you were lucky (or, more arguably, there is a Makefile bug). So the best advice is to future-proof yourself: keep very close tabs on the use of SCTP symbols and definitions outside of the core code, especially in modules, and make sure you're entirely happy with KPI/KBI exposures from inception.
More information about the svn-src-all